pop() performs better than shift()

Rename method
Brexbot · Jan 6, 2024 · 9a52305 · 9a52305
1 parent 8f7a26c
commit 9a52305
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/commands/chatters/artemis.ts b/src/commands/chatters/artemis.ts
@@ -50,13 +50,13 @@ class Artemis {
 
   protected shuffledBag: string[] = []
 
-  private getFact(): string | undefined {
+  private get_fact(): string | undefined {
     if (!this.shuffledBag.length) {
       this.shuffledBag = [...this.facts]
       shuffleArray(this.shuffledBag)
     }
 
-    return this.shuffledBag.shift()
+    return this.shuffledBag.pop()
   }
 
   @SimpleCommand({ name: 'artemis', description: 'Artemis' })
@@ -65,7 +65,7 @@ class Artemis {
     command: SimpleCommandMessage
   ) {
     await command.message.channel.send({
-      content: this.getFact(),
+      content: this.get_fact(),
     })
     return
   }