Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MI-3423]: Added checks for every post API body #3

Merged
merged 3 commits into from
Aug 29, 2023
Merged

[MI-3423]: Added checks for every post API body #3

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9666d
[MI-3423]: Added checks for every post API body
Kshitij-Katiyar Aug 28, 2023
8dae731
[MI-3423]:Fixed review comments
Kshitij-Katiyar Aug 29, 2023
6653675
[MI-3423]:Fixed review comments
Kshitij-Katiyar Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions server/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ func (p *Plugin) handleTelemetry(w http.ResponseWriter, r *http.Request) {

telemetryRequest, err := GetTelemetryPayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get telemetry payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get telemetry payload from json.", err)
p.API.LogError("Unable to get telemetry payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get telemetry payload from JSON.", err)
return
}

Expand All @@ -188,8 +188,8 @@ func (p *Plugin) handleAdd(w http.ResponseWriter, r *http.Request) {

addRequest, err := GetAddIssuePayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get add issue payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get add issue payload from json.", err)
p.API.LogError("Unable to get add issue payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get add issue payload from JSON.", err)
return
}

Expand Down Expand Up @@ -345,8 +345,8 @@ func (p *Plugin) handleEdit(w http.ResponseWriter, r *http.Request) {

editRequest, err := GetEditIssuePayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get edit issue payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get edit issue payload from json.", err)
p.API.LogError("Unable to get edit issue payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get edit issue payload from JSON.", err)
return
}

Expand Down Expand Up @@ -385,8 +385,8 @@ func (p *Plugin) handleChangeAssignment(w http.ResponseWriter, r *http.Request)

changeRequest, err := GetChangeAssignmentPayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get change request payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get change request from json.", err)
p.API.LogError("Unable to get change request payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get change request from JSON.", err)
return
}

Expand Down Expand Up @@ -431,8 +431,8 @@ func (p *Plugin) handleAccept(w http.ResponseWriter, r *http.Request) {

acceptRequest, err := GetAcceptRequestPayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get accept request payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get accept request from json.", err)
p.API.LogError("Unable to get accept request payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get accept request from JSON.", err)
return
}

Expand Down Expand Up @@ -463,13 +463,13 @@ func (p *Plugin) handleComplete(w http.ResponseWriter, r *http.Request) {

completeRequest, err := GetCompleteIssuePayloadFromJSON(r.Body)
manojmalik20 marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
p.API.LogError("Unable to get complete request payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get complete request from json.", err)
p.API.LogError("Unable to get complete request payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get complete request from JSON.", err)
return
}

if err := IsCompleteIssuePayloadValid(completeRequest); err != nil {
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to validate complete request payload.", err)
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to validate complete issue request payload.", err)
return
}

Expand Down Expand Up @@ -503,13 +503,13 @@ func (p *Plugin) handleRemove(w http.ResponseWriter, r *http.Request) {

removeRequest, err := GetRemoveIssuePayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get remove request payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get remove request from json.", err)
p.API.LogError("Unable to get remove request payload from JSON err=" + err.Error())
Kshitij-Katiyar marked this conversation as resolved.
Show resolved Hide resolved
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get remove request from JSON.", err)
return
}

if err := IsRemoveIssuePayloadValid(removeRequest); err != nil {
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to validate remove request payload.", err)
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to validate remove issue request payload.", err)
return
}

Expand Down Expand Up @@ -549,8 +549,8 @@ func (p *Plugin) handleBump(w http.ResponseWriter, r *http.Request) {

bumpRequest, err := GetBumpIssuePayloadFromJSON(r.Body)
if err != nil {
p.API.LogError("Unable to get bump request payload from json=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get bump request from json.", err)
p.API.LogError("Unable to get bump request payload from JSON err=" + err.Error())
p.handleErrorWithCode(w, http.StatusBadRequest, "Unable to get bump request from JSON.", err)
return
}

Expand Down