Updates to Google Maps API response handling and field requirements #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewminion-luminfire
requested changes
Aug 7, 2019
Contributor
andrewminion-luminfire
left a comment
andrewminion-luminfire
left a comment
There was a problem hiding this comment.
Could you update the readme changelog with v0.0.3 changes? Looks like you removed v0.0.2—not sure if that was intentional or not.
Updated readme change log and links that have since changed
Author
|
Sorry about that I was a little confused, I added the missing info back into the readme and added 0.0.3 info to the changelog along with some url updates |
andrewminion-luminfire
approved these changes
Aug 9, 2019
Contributor
andrewminion-luminfire
left a comment
andrewminion-luminfire
left a comment
There was a problem hiding this comment.
Without having tested it, the code changes look good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes to how the Google Maps API response is handled and set the ability to match up multiple fields when Google Maps is set to be the geocoder.