Skip to content

Feat: implemented get_project_transactions function#57

Merged
anonfedora merged 6 commits intoBudgetChain:mainfrom
caxtonacollins:#46
Apr 29, 2025
Merged

Feat: implemented get_project_transactions function#57
anonfedora merged 6 commits intoBudgetChain:mainfrom
caxtonacollins:#46

Conversation

@caxtonacollins
Copy link
Copy Markdown
Contributor

closes #46

  • Added a double map storage pattern to track transaction IDs per project.
  • Implemented get_project_transactions with pagination (page, page_size) and robust input validation.
  • Updated create_transaction to maintain the project-to-transaction mapping.
  • Added comprehensive unit tests covering:
  • Pagination and edge cases (no transactions, single transaction, invalid parameters)
  • Data integrity and correct ordering
  • Multiple project isolation
  • Added NatSpec documentation to both the interface and contract implementation.

@caxtonacollins
Copy link
Copy Markdown
Contributor Author

closes #46 please review

@anonfedora
Copy link
Copy Markdown
Contributor

Hi @caxtonacollins, your PR isn't passing the CI, and I'm yet to.hear from you, I need a PR within 6 hours or I'd have to reassign

@anonfedora
Copy link
Copy Markdown
Contributor

Fix conflicts, please

@caxtonacollins
Copy link
Copy Markdown
Contributor Author

closes #46
@anonfedora Fixed

@anonfedora anonfedora merged commit ac7d024 into BudgetChain:main Apr 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement get_project_transactions Function in Budget Contract

2 participants