-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes #14982
base: master
Are you sure you want to change the base?
Misc fixes #14982
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the all the issues listed here and have some feedback
-
The display column is now showing on the left as expected when a table uses a data provider. Also, the upload field changes are working perfectly 👍
-
The CreateEditColumn popover change is visible when editing an existing column but not when creating a new one. Could this be extended to the create flow as well?
-
When adding multiple attachments to the same single attachment field, I still see the same behaviour
It's the same component, and it definitely is there for creating a new column... What did you click to see the small one? How did you add multiple? You can't select more than one file in the file picker now (unless it's a multi attachment column of course), and you can't upload a new one until you delete the current file. |
Description
Old (very cramped and cut off):
New: