Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #14982

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Misc fixes #14982

wants to merge 11 commits into from

Conversation

aptkingston
Copy link
Member

@aptkingston aptkingston commented Nov 6, 2024

Description

Copy link

qa-wolf bot commented Nov 6, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added the size/s label Nov 6, 2024
@aptkingston aptkingston marked this pull request as ready for review November 6, 2024 16:42
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the all the issues listed here and have some feedback

  • The display column is now showing on the left as expected when a table uses a data provider. Also, the upload field changes are working perfectly 👍

  • The CreateEditColumn popover change is visible when editing an existing column but not when creating a new one. Could this be extended to the create flow as well?

  • When adding multiple attachments to the same single attachment field, I still see the same behaviour
    Screenshot 2024-11-15 at 12 39 53

@aptkingston
Copy link
Member Author

  • The CreateEditColumn popover change is visible when editing an existing column but not when creating a new one. Could this be extended to the create flow as well?

It's the same component, and it definitely is there for creating a new column... What did you click to see the small one?

Creating: 360 width
image

Editing: 360 width
image

  • When adding multiple attachments to the same single attachment field, I still see the same behaviour
    Screenshot 2024-11-15 at 12 39 53

How did you add multiple? You can't select more than one file in the file picker now (unless it's a multi attachment column of course), and you can't upload a new one until you delete the current file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants