add support for internal account portal URL #15830
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
reviewed
Mar 27, 2025
adrinr
reviewed
Apr 1, 2025
| @@ -162,6 +162,8 @@ const environment = { | |||
| MULTI_TENANCY: process.env.MULTI_TENANCY, | |||
| ACCOUNT_PORTAL_URL: | |||
| process.env.ACCOUNT_PORTAL_URL || "https://account.budibase.app", | |||
| INTERNAL_ACCOUNT_PORTAL_URL: | |||
There was a problem hiding this comment.
Should this be ACCOUNT_PORTAL_URL?
There was a problem hiding this comment.
There's already an ACCOUNT_PORTAL_URL on the line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the provision of an
INTERNAL_ACCOUNT_PORTAL_URLthat can be used for service communication without leaving the private network