Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(math): Add Ellipse Component #42

Closed
wants to merge 1 commit into from

Conversation

xs10l3
Copy link
Collaborator

@xs10l3 xs10l3 commented Nov 10, 2024

  • Implemented a new Ellipse Component for drawing ellipse shapes in the Math Extension
  • The component supports custom properties such as center point, long axis, and short axis
  • Use the definitions and properties of the Vue Motion library to implement component functionality

name: Contribute to VueMotion
about: Have a contribution to VueMotion! Thank you!

Description: [Please describe the background, purpose, changes made, and how to test this PR]

Related Issues: [List the issue numbers related to this PR]

TODO

  • task1
  • ...

Checklist:

  • Code has been reviewed
  • [x ] Code complies with the project's code standards and best practices
  • [ x] Code has passed all tests
  • Code does not affect the normal use of existing features
  • Documentation has been updated

Screenshots: [Provide relevant screenshots or GIF animations]

- Implemented a new Ellipse Component for drawing ellipse shapes in the Math Extension
- The component supports custom properties such as center point, long axis, and short axis
- Use the definitions and properties of the Vue Motion library to implement component functionality
@sheepbox8646
Copy link
Member

I think it are supposed to be section in core lib rather than math... And SVG has ellipse tag so that you can use it instead of the ellipse equation... It's performance will be higher...

@xs10l3 xs10l3 changed the title feat(math): Add Ellipse Component [WIP] feat(math): Add Ellipse Component Nov 10, 2024
@xs10l3 xs10l3 closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants