Update PURE mixture, mechanisms, and parameters#322
Draft
murrayrm wants to merge 6 commits intoBuildACell:mainfrom
Draft
Update PURE mixture, mechanisms, and parameters#322murrayrm wants to merge 6 commits intoBuildACell:mainfrom
murrayrm wants to merge 6 commits intoBuildACell:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT PR. Putting this out so people can see the changes coming, but still working on a few things:
plot_all_species_containingThis PR makes a number changes to the way that PURE is implemented:
PUREmixture that uses parameters to turn on/off the use of machinery, resources, and fuel. This means that we don't need separateSimplePURE,EnergyPURE, etc. The oldBasicPUREmixture is now just a call toPURE.In addition, some changes that go beyond PURE were also implemented:
plot_all_species_containing) or gene expression data (plot_gene_expression_data).attributesto always pass a list (rather than a string). This addresses the issue pointed out by @zjuradoq in PR updated parameter processing #320. (Note: we might want to instead add a check for an attribute passed as a string and just create a list when we see it.)Sample plot for
plot_all_species_containing(from TBD):Sample plot for
plot_gene_expression_data(fromgfp_expression.py):