Skip to content

ignore: add support for WASI#2994

Closed
Timmmm wants to merge 1 commit intoBurntSushi:masterfrom
Timmmm:user/timh/wasi
Closed

ignore: add support for WASI#2994
Timmmm wants to merge 1 commit intoBurntSushi:masterfrom
Timmmm:user/timh/wasi

Conversation

@Timmmm
Copy link

@Timmmm Timmmm commented Feb 20, 2025

Add support for compiling to wasm32-wasip2. For this target WalkParallel becomes single threaded. This allows projects that depend on ignore to be compiled for WASI without having to modify their code.

Note this depends on a corresponding PR for walkdir so it won't compile currently.

To test add this to Cargo.toml:

[patch.crates-io]
walkdir = { git = "https://github.com/Timmmm/walkdir.git", branch = "user/timh/wasi" }

Add support for compiling to `wasm32-wasip2`. For this target `WalkParallel` becomes single threaded. This allows projects that depend on `ignore` to be compiled for WASI without having to modify their code.
@BurntSushi
Copy link
Owner

See conversation in BurntSushi/walkdir#205

In summary, unless there is an exceptionally good reason to, I generally don't add support for nightly only stuff to libraries. I've done it in the past, and it's almost always been a maintenance headache.

I'd be happy to have these PRs re-submitted once they use stable APIs.

@BurntSushi BurntSushi closed this Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants