Closed
Conversation
Add support for compiling to `wasm32-wasip2`. For this target `WalkParallel` becomes single threaded. This allows projects that depend on `ignore` to be compiled for WASI without having to modify their code.
ae42916 to
fddbd40
Compare
Owner
|
See conversation in BurntSushi/walkdir#205 In summary, unless there is an exceptionally good reason to, I generally don't add support for nightly only stuff to libraries. I've done it in the past, and it's almost always been a maintenance headache. I'd be happy to have these PRs re-submitted once they use stable APIs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for compiling to
wasm32-wasip2. For this targetWalkParallelbecomes single threaded. This allows projects that depend onignoreto be compiled for WASI without having to modify their code.Note this depends on a corresponding PR for
walkdirso it won't compile currently.To test add this to
Cargo.toml: