Conversation
BurntSushi
left a comment
There was a problem hiding this comment.
I am open to doing this, but I want to make sure this has no breaking changes. I don't think there are any, but could you please think through that and provide an argument as to why?
Also, this will need:
- Added documentation, since this adds public API surface. For example, here: https://docs.rs/termcolor/1.1.2/termcolor/enum.Color.html
- Tests. This should be pretty thoroughly tested.
|
I added some tests and limited the string length to be 7 so My reasoning for why it's not braking change:
For documentation, did you mean a line there or would you like some short example usage? |
It should document the format, at minimum. e.g., "A |
|
Any progress? |
I find it more convenient to keep colors in
#rrggbbformat so added support for thatThanks for the grate lib btw!