fix(vm): correct BC17 DUP swap-mode operand decoding#340
Draft
emiyl wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Not super well versed in the VM, will research this a bit to be sure before merging! |
Collaborator
|
You'll need to fix CI btw |
emiyl
marked this pull request as draft
July 24, 2026 16:46
Contributor
Author
|
Marked as draft as it seems to break erasing saves |
Collaborator
|
Well it's the save menu itself I think, I haven't tested trying to select an option other than Erase but I reckon it'll be the same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash in chapter 5 when building Susie's outfit