Skip to content

Commit

Permalink
render-dialog: set all properties together
Browse files Browse the repository at this point in the history
Fixes spurious error we got due to partial initialisation.
  • Loading branch information
ensonic committed Sep 3, 2015
1 parent bce4a2d commit 461bcb8
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/ui/edit/render-dialog.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ bt_render_dialog_record (const BtRenderDialog * self)

GST_INFO ("recording to '%s'", self->priv->file_name);
g_object_set (self->priv->sink_bin, "record-file-name", self->priv->file_name,
NULL);
// TODO(ensonic): BT_SINK_BIN_MODE_PLAY_AND_RECORD hangs
"mode", BT_SINK_BIN_MODE_RECORD,
"record-format", self->priv->format, NULL);
info = g_strdup_printf (_("Recording to: %s"), self->priv->file_name);
gtk_label_set_text (self->priv->info, info);
g_free (info);
Expand Down Expand Up @@ -231,11 +233,6 @@ bt_render_dialog_record_init (const BtRenderDialog * self)
g_object_get (machine, "machine", &self->priv->sink_bin, "adder-convert",
&self->priv->convert, NULL);

g_object_set (self->priv->sink_bin, "mode", BT_SINK_BIN_MODE_RECORD,
// TODO(ensonic): this hangs :/
//"mode",BT_SINK_BIN_MODE_PLAY_AND_RECORD,
"record-format", self->priv->format, NULL);

/* TODO(ensonic): configure dithering/noise-shaping
* - should sink-bin do it so that we get this also when recording from
* the commandline (need some extra cmdline options for it :/
Expand Down

0 comments on commit 461bcb8

Please sign in to comment.