Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve download translation script #151

Merged

Conversation

rffontenelle
Copy link
Contributor

The reasons are explained in the commits, but here is a summary:

  • Fix issues in my previous "variables rename" commit
  • Fix verification of binary availability, and include check for msguniq as gettext package could not be available
  • Make LANGUAGES_UPDATED variable exclusively for updated translation files, changing the final info output for that fact
  • Add language codes from Translation Project that are not listed in the script
  • Add prefixes ::error::some error text here and ::warning::some warning here to include annotation when running in GitHub Actions (which is a WIP right now)

# check for 'diff' program
diff --version 2>/dev/null >/dev/null
if [ $? -ne 0 ]; then
echo "==== You must have the 'diff' program installed for this script ===="
exit 1
err_msg "==== You must have the 'diff' program installed for this script ===="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this you can actually write:
diff --version 2>/dev/null >/dev/null | err_msg "==== You must have the 'diff' program installed for this script ===="

(also below)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, we can also omit the "===="

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, reduced some lines.

@ensonic
Copy link
Member

ensonic commented Feb 26, 2024

thanks a lot!

@ensonic ensonic merged commit 9a538fc into Buzztrax:master Feb 27, 2024
1 check failed
@rffontenelle rffontenelle deleted the improve-download-translation-script branch February 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants