fix(windows): pass canonicalized path to ILCreateFromPathW#116
Merged
Byron merged 2 commits intoByron:mainfrom Nov 17, 2025
Merged
fix(windows): pass canonicalized path to ILCreateFromPathW#116Byron merged 2 commits intoByron:mainfrom
ILCreateFromPathW#116Byron merged 2 commits intoByron:mainfrom
Conversation
Owner
|
Thanks a lot for the fix! |
Owner
|
And here it is: https://github.com/Byron/open-rs/releases/tag/v5.3.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tauri-apps/plugins-workspace#3102
Use
canonicalizeinstead ofsimplifiedhere to allow mixed path seperators to work (e.g.C:\Program Files/Some App)Also added a null check guard on
ILCreateFromPathWfor cases where we have reachedMAX_PATHlimit or hit other errors to preventSHOpenFolderAndSelectItemsfrom hangingFinally added
ILFreefor theITEMIDLISTreturned fromILCreateFromPathWwhich I forgot to add in #104