Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.2 #670

Merged
merged 7 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ REACT_APP_TAG_EDITORIAL=editorial
REACT_APP_ENABLE_AUTH_0=false
REACT_APP_TWITTER=Journal_DigHist
REACT_APP_FACEBOOK=journalofdigitalhistory
REACT_APP_BLUESKY=jdighist.bsky.social
REACT_APP_THEBE_TOKEN=********
REACT_APP_THEBE_DEV_BINDER=false
REACT_APP_THEBE_JUPYTER_URL=http://localhost:8888
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jdh",
"version": "5.0.1",
"version": "5.0.2",
"private": true,
"dependencies": {
"@auth0/auth0-react": "^1.1.0",
Expand Down
20 changes: 20 additions & 0 deletions src/assets/images/bluesky.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 4 additions & 3 deletions src/components/Footer/Footer.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ import {
ReviewPolicy,
FaqRoute
} from '../../constants'
import { Twitter, Facebook, GitHub } from 'react-feather'
import { Facebook, GitHub } from 'react-feather'
import DeGruyterLogo from '../../assets/images/Verlag_Walter_de_Gruyter_Logo_Oldenbourg.svg'
import UniluLogo from '../../assets/images/unilu-c2dh-logo.svg'
import { ReactComponent as BlueskyIcon } from '../../assets/images/bluesky.svg';
import '../../styles/components/Footer.scss'


Expand Down Expand Up @@ -80,8 +81,8 @@ const Footer = ({ hideOnRoutes=[]}) => {
<Col {...BootstrapFullColumLayout}>
<div className="border-top pt-3 mt-3 d-md-flex justify-content-center">
<div className="me-3 mb-3 mb-md-0 ">
<a className="plain-a" href={`https://twitter.com/${process.env.REACT_APP_TWITTER}`} target="_blank" rel="noreferrer">
<Twitter size={15}/> @{process.env.REACT_APP_TWITTER}
<a className="plain-a" href={`https://bsky.app/profile/${process.env.REACT_APP_BLUESKY}`} target="_blank" rel="noreferrer">
<BlueskyIcon style={{width: '15px'}} /> @{process.env.REACT_APP_BLUESKY}
</a>
</div>
<div className="d-none d-md-block"> &middot;</div>
Expand Down
1 change: 1 addition & 0 deletions src/pages/ArticleViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ const ArticleViewer = ({
doi={article.doi}
issue={article.issue}
bibjson={article.citation}
parserVersion={parseInt(article.data.parserVersion) || 2}
isJavascriptTrusted
match={{
params: {
Expand Down
3 changes: 2 additions & 1 deletion src/pages/NotebookViewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ const NotebookViewer = ({
bibjson,
pid,
isJavascriptTrusted,
parserVersion = 2
}) => {
const [{ [ArticleVersionQueryParam]: version }] = useQueryParams({
[ArticleVersionQueryParam]: withDefault(NumberParam, 2),
[ArticleVersionQueryParam]: withDefault(NumberParam, parserVersion),
})
const ArticleComponent = version === 3 ? ArticleV3 : version === 2 ? ArticleV2 : Article
const setLoadingProgress = usePropsStore((state) => state.setLoadingProgress)
Expand Down
Loading