Skip to content

Conversation

@jcanton
Copy link
Contributor

@jcanton jcanton commented Jan 22, 2026

Add cartesian coordinates to serialized data (sync with https://github.com/C2SM/icon-exclaim/pull/406 AND UPDATE CI DATA)
this allows for testing of the math/helpers.py::geographical_to_cartesian_on_xyz functions
it will also allow for MPI tests on torus #692 which need serialized decomposed grid cartesian coordinates

@jcanton jcanton requested a review from msimberg January 22, 2026 17:48
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanton!

I'm a bit confused how this passes in CI, but is it because the github workflows don't run datatests? At least I couldn't find any quickly. I suppose you didn't re-serialize all the experiments, and if that's the case I would expect the test_geometry.py tests to fail for spherical grids (which is ok, as discussed; in that case we make the comparison to serialized data conditional on the geometry type in the tests).

@jcanton
Copy link
Contributor Author

jcanton commented Jan 23, 2026

I didn't trigger the CI (cscs/default) which would not yet pass no. I'm waiting for @OngChia to decide together what to do with the Weisman Klemp experiment so I update everything only once

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants