Fix data download paths

[msimberg]

Attempting to fix data downloads after #1002.

With my current understanding of how the downloads work, the download and extraction should happen in the "root" directory (_ranked_data_path), but the tarball actually contains subdirectories which match the experiment-specific subdirectory (which is what we check for to see if the data already exists).

I've tested re-downloading one grid and that worked. Please test it on your local setups to see I haven't messed something up.

[havogt]

Thanks for the fix! With the suggested change, my use-case would be covered as well. I tested a few cases and seems good.

[havogt]

Note, unrelated to this PR I opened #1021 which might result in weird errors if you run into the problem.

[havogt]

In #1004 I would consider taring without subdirectories which gives more flexibility, and we can move back to the simpler version without subdir.

[jcanton]

looks good to me, also tested locally and works

[jcanton]

In #1004 I would consider taring without subdirectories which gives more flexibility, and we can move back to the simpler version without subdir.

ok, but I can make this change in PR1004, not here
(moreover, if we include the NAMELIST dump so we can improve the experiment config (like I did now in #1004), it could still make sense to have the actual data separate in its own subdir as it is now)

[jcanton]

LGTM.2 ;-)

[havogt]

Tested and works (including the muphys use-case).

[github-actions]

Mandatory Tests

Please make sure you run these tests via comment before you merge!

• cscs-ci run default
• cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

• cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

• cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

• cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.