-
Notifications
You must be signed in to change notification settings - Fork 8
Add dace backend to default CI pipeline #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
6b1657e
Add dace backend to default CI pipeline
edopao b0aa173
edit CI reminder message
edopao 331a47d
edit
edopao bef3aef
edit
edopao 4dba6d0
revert timeout on stencil tests for advection
edopao 558a814
edit
edopao ded060c
Merge branch 'main' into enable_dace_ci_tests
edopao 45fc867
include gt4py fix
edopao da6b6fe
Test passed with gt4py fix, reverting custom branch
edopao 23fc6ee
Merge branch 'main' into enable_dace_ci_tests
philip-paul-mueller 0a6f7d4
Reenabled GT4Py main and updated DaCe.
philip-paul-mueller e4709cd
Fixed typo.
philip-paul-mueller 4172d08
Test my fix, but it worked locally.
philip-paul-mueller 0d56c05
NEW STATE
philip-paul-mueller 4c04017
Updated GT4Py to the newest version.
philip-paul-mueller 068c0b1
Merge remote-tracking branch 'origin/main' into keep_icon4py_alive_wi…
philip-paul-mueller c37361a
Merge branch 'main' into keep_icon4py_alive_with_dace
philip-paul-mueller 819ebdc
Let's hope that this makes the output more readable.
philip-paul-mueller 136fc7e
Merge remote-tracking branch 'origin/main' into keep_icon4py_alive_wi…
philip-paul-mueller 1288e5e
Fixed a possible error.
philip-paul-mueller a7f74fc
Revert "Updated GT4Py to the newest version."
philip-paul-mueller 2577243
Maybe; GT4Py still contains the poison, but it is not found.
philip-paul-mueller b726a7b
Now this should fail because it is still the one with the poisson.
philip-paul-mueller 12e0f9e
Let's use the new version.
philip-paul-mueller a705165
It must be a copy because otherwise they would share the same data.
philip-paul-mueller 9a55769
Revert "Let's hope that this makes the output more readable."
philip-paul-mueller dbbe852
Merge remote-tracking branch 'origin/main' into keep_icon4py_alive_wi…
philip-paul-mueller 009a074
Applied the new formating rule.
philip-paul-mueller 8e60f70
Super strange ruff bug.
philip-paul-mueller 74f422f
Used Hannes Idea
philip-paul-mueller 4d01f0f
Revert "Super strange ruff bug."
philip-paul-mueller 56d5ff2
Revert "Applied the new formating rule."
philip-paul-mueller 4b57c7f
JJKJ
philip-paul-mueller b089a39
Thanks to Hannes and Enrique now it passes.
philip-paul-mueller c7cf596
Merge branch 'main' into enable_dace_ci_tests
edopao 0bf6e50
update uv lock
edopao 0f9d50a
update gt4py and dace version
edopao 4fe8c51
Merge branch 'main' into fix_advection_test
edopao 5e382cb
cleanup
edopao f2133e8
Merge branch 'main' into keep_icon4py_alive_with_dace
edopao 43afd61
change gt4py branch
edopao 60aa807
Merge branch 'keep_icon4py_alive_with_dace' into enable_dace_ci_tests
edopao eab78e4
Merge branch 'fix_advection_test' into enable_dace_ci_tests
edopao 7f7834b
update uv lock
edopao 7b453b1
Merge branch 'main' into enable_dace_ci_tests
edopao 3f4f91c
update dace version
edopao ee7be35
Merge branch 'main' into enable_dace_ci_tests
edopao c4de0cb
update uv lock
edopao 1538c36
update uv lock
edopao c8c0f06
update uv lock
edopao 2eb2076
Merge branch 'main' into enable_dace_ci_tests
edopao e557c90
update uv lock
edopao e35be18
update uv lock
edopao 7b72795
update uv lock
edopao 4e181ba
increase timeout
edopao e7e03ff
increase timeout
edopao 2196ffe
update uv lock
edopao 9c4e4e5
increase timeout
edopao 9a53c60
update uv lock
edopao 3ea6f66
update uv lock
edopao 3b665fd
increase timeout
edopao 535d6e4
update uv lock
edopao dabaafd
update uv lock
edopao a1af5cb
Merge branch 'main' into enable_dace_ci_tests
edopao 71a27c3
undo extra change
edopao a1149c7
edit
edopao 0b55d50
edit
edopao 150d065
edit
edopao 70d9ac5
fix memory allocator for empty fields
edopao 14196d5
edit comment
edopao 6cfe262
remove todo comment
edopao e478a67
Merge branch 'main' into enable_dace_ci_tests
edopao 4811c34
Merge branch 'fix_memory_allocator' into enable_dace_ci_tests
edopao 01b8b92
Merge branch 'main' into enable_dace_ci_tests
edopao b4218f6
edit
edopao caa8c5e
edit
edopao 2dde84d
edit
edopao 68da360
edit
edopao 29d19d4
edit
edopao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this is correct here.
GT4Py needs a specific DaCe version, set in GT4Py's
pyproject.tomlfile. Furthermore, ICON4Py follows GT4Py main, i.e. not a specific tag or so.This means that the DaCe version inherited through GT4Py and the one that is specified here, might be different.