Skip to content

Conversation

@huppd
Copy link
Contributor

@huppd huppd commented Oct 21, 2025

  • add package for ghex
  • add package for hwmalloc
  • add package for icon-exclaim
  • add package for oomph
  • add package for uv

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2025-11-28 12:47 UTC

@msimberg
Copy link

This is an optional request, but for testing of NCCL for halo exchanges it'd be very nice to have up-to-date versions of nccl, aws-ofi-nccl, and libfabric. The latest versions are all available on the new spack-packages repo, but are of course not here on the old version of spack.

I suspect that it's maybe better to leave updating these out of this PR so as not to block it further? But for planning is here or in https://github.com/C2SM/software-stack-recipes the better place to put such updated package recipes? This could possibly be added as part of C2SM/software-stack-recipes#33.

@huppd
Copy link
Contributor Author

huppd commented Oct 31, 2025

This is an optional request, but for testing of NCCL for halo exchanges it'd be very nice to have up-to-date versions of nccl, aws-ofi-nccl, and libfabric. The latest versions are all available on the new spack-packages repo, but are of course not here on the old version of spack.

I suspect that it's maybe better to leave updating these out of this PR so as not to block it further? But for planning is here or in https://github.com/C2SM/software-stack-recipes the better place to put such updated package recipes? This could possibly be added as part of C2SM/software-stack-recipes#33.

I would keep these out of this MR just to keep the history clean. But for where is the best place to put them, I think for playing around this is the better place, but hopefully we can kind of converge to the spack main repo.

@msimberg
Copy link

This is an optional request, but for testing of NCCL for halo exchanges it'd be very nice to have up-to-date versions of nccl, aws-ofi-nccl, and libfabric. The latest versions are all available on the new spack-packages repo, but are of course not here on the old version of spack.
I suspect that it's maybe better to leave updating these out of this PR so as not to block it further? But for planning is here or in https://github.com/C2SM/software-stack-recipes the better place to put such updated package recipes? This could possibly be added as part of C2SM/software-stack-recipes#33.

I would keep these out of this MR just to keep the history clean. But for where is the best place to put them, I think for playing around this is the better place, but hopefully we can kind of converge to the spack main repo.

Yep, absolutely. Thanks for the response. I found out about the plans to move to spack 1.0 (which would bring newer packages) in the near future which would cover this use case. Until then I'm attempting to build a slimmer new icon uenv (only dependencies) based on a newer spack 1.0 stack which would cover my testing needs for now.

Copy link
Contributor Author

@huppd huppd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the valuable feedback @msimberg and @havogt I hope I addressed them all now.

@huppd huppd marked this pull request as ready for review November 5, 2025 13:02
Copy link

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, but I'm picking nits. This looks good to me as it is.

@AnnikaLau
Copy link
Contributor

cscs-ci run santis

@AnnikaLau
Copy link
Contributor

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 5, 2025

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 5, 2025

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 6, 2025

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 6, 2025

launch jenkins

@huppd
Copy link
Contributor Author

huppd commented Nov 18, 2025

launch jenkins

@huppd
Copy link
Contributor Author

huppd commented Nov 24, 2025

launch jenkins

@huppd
Copy link
Contributor Author

huppd commented Nov 24, 2025

cscs-ci run

@huppd
Copy link
Contributor Author

huppd commented Nov 28, 2025

launch jenkins

@huppd huppd merged commit b4a5d42 into main Nov 28, 2025
4 checks passed
@huppd huppd deleted the add_icon4py branch November 28, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants