Detailed logging for decryption/validation #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the server is unable to verify an email, and "Valid signatures only" is enabled, it logs
MailHandler: ignoring emails with invalid signature
. This is helpful because otherwise the message is dropped with no indication to the sender or the Redmine administator.However, it lacks details that could assist troubleshooting. Ideally, the log message would also include the sender and a unique ID for the message (e.g.
Message-ID
), so an administrator could try to troubleshoot the problem (and potentially recover and examine emails that were rejected from the IMAP server).Additionally, some servers might like to try to enforce or strongly encourage that all incoming mail is encrypted (in addition to encrypting outgoing mail, which is handled by redmine_openpg). I filed #9 to address this with a comprehensive feature, but as a stop-gap measure it would be helpful for an administrator to be able to determine if their Redmine instance is receiving unencrypted mail.
This pull request:
The new log lines look like this: