Validate with all signing subkeys #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
This works, but is unfortunately affected by an issue in
ruby-gpgmewhere it incorrectly reports that all subkeys have every capability (I just filed ueno/ruby-gpgme#76 for this). This will not cause any breakage. It just means that until the ruby-gpgme issue is fixed, the identity comparison will compare the fingerprint of the key that generated the signature (s.fpr) against every subkey, instead of just the subkeys that have the sign capability, becauseruby-gpgmecurrently incorrectly reports that every subkey has every capability.Since GPG will only generate signatures from signing subkeys, I do not believe this will cause any problems in practice.