Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend integration #133

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

Maxwell-Lindsey
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uiuc-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:29pm

Copy link
Contributor

sweep-ai bot commented Mar 25, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@Maxwell-Lindsey Maxwell-Lindsey changed the base branch from main to advanced-document-controls-ui March 30, 2024 16:04
Base automatically changed from advanced-document-controls-ui to main April 6, 2024 17:47
Copy link
Collaborator

@KastanDay KastanDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality looks good from a quick skim. I'm hoping Rohan can test all endpoints to make sure we don't have any small errors/regressions. Thanks Max!

@rohan-uiuc
Copy link
Collaborator

rohan-uiuc commented May 20, 2024

After adding FLASK_URL to env variables, following are the testing results:

  1. /getTopContexts gives 405, probably because process.env variables are not available in edge runtime
  2. /export-convo-history gives 404 because endpoint name is downloadConvoHistory
  3. /deleteDocuments works fine
  4. Nomic endpoints are working but not returning data, which might be a separate issue.
  5. logConversationToFlask works fine
  6. Did not test MIT, Canvas ingest, /getExtremePrompt and /getTopContextsMQR

@KastanDay
Copy link
Collaborator

Canvas works (or should!) and MIT is TBD... I want it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants