-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unit Tests for chat.ts #79
Open
sweep-ai
wants to merge
7
commits into
main
Choose a base branch
from
sweep/unit-tests-chat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollback Files For Sweep
|
Sandbox Executions
Check src/pages/api/__tests__/chat.test.ts with contents:
Check src/pages/api/chat.ts with contents: |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
I created this PR to address this rule:
"All new business logic should have corresponding unit tests."
Description
This PR introduces unit tests for the business logic in
src/pages/api/chat.ts
. The tests cover various scenarios and edge cases, ensuring the correctness and stability of the code.Changes were made to
src/pages/api/chat.ts
to make the code more testable. This includes exporting the handler function and other necessary functions or constants, and refactoring some parts of the code to make it easier to test each piece of functionality in isolation.A new file
src/pages/api/__tests__/chat.test.ts
was created to house the unit tests. This file imports the necessary functions and constants fromsrc/pages/api/chat.ts
and defines a series of test cases that cover all the different scenarios and edge cases.Summary of Changes
src/pages/api/__tests__/chat.test.ts
for unit tests.src/pages/api/chat.ts
to export necessary functions and constants for testing.src/pages/api/chat.ts
to make the code more testable.Please review the changes and let me know if there are any concerns or suggestions for improvement.