Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior when creating new course; Redirect to /materials #86

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix behavior when creating new course; Redirect to /materials #86

merged 1 commit into from
Dec 20, 2023

Conversation

KastanDay
Copy link
Collaborator

Tested for both file upload and webscrape. Redirects even if no documents exist yet (using KV project metadata store).

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uiuc-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 3:06am

@KastanDay KastanDay requested a review from rohan-uiuc December 20, 2023 03:05
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 20, 2023
View reviewed changes
src/components/UIUC-Components/LargeDropzone.tsx Dismissed Show dismissed Hide dismissed
src/components/UIUC-Components/WebScrape.tsx Dismissed Show dismissed Hide dismissed
src/components/UIUC-Components/LargeDropzone.tsx Dismissed Show dismissed Hide dismissed
src/components/UIUC-Components/WebScrape.tsx Dismissed Show dismissed Hide dismissed
@KastanDay KastanDay changed the title Fi behavior when creating new course; Redirect to /materials Fix behavior when creating new course; Redirect to /materials Dec 20, 2023
@KastanDay KastanDay merged commit f47ee0e into main Dec 20, 2023
4 checks passed
@KastanDay KastanDay deleted the fix_creation_behavior_on_new_project branch December 20, 2023 19:55
hanlily666 pushed a commit that referenced this pull request Jan 23, 2024
@KastanDay
On new course creation, properly redirect to /materials page (#86)
1402325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-uiuc rohan-uiuc rohan-uiuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KastanDay @rohan-uiuc