Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

29 implement undo redo feature #36

Merged
merged 9 commits into from
Mar 2, 2023

Conversation

vulongphan
Copy link
Collaborator

This PR implements undo-redo feature and add corresponding unit tests

@vulongphan
Copy link
Collaborator Author

Link to #29 #33 #15

@muhammed-abuodeh
Copy link
Collaborator

If you drag a node and release it, it'll be floating.

@vulongphan
Copy link
Collaborator Author

I cannot reproduce the bug on this branch. Did you pull the most up-to-date version of it?

@muhammed-abuodeh
Copy link
Collaborator

I cannot reproduce the bug on this branch. Did you pull the most up-to-date version of it?
Got it working, thanks!

There is another bug I spotted. Do the following to reproduce:
collapse node
move node 4 times
undo 3 times
expand node

@muhammed-abuodeh
Copy link
Collaborator

Issue with d3 functionality, not the new feature.

@muhammed-abuodeh muhammed-abuodeh merged commit 2d468b3 into master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants