Allow content edit and translation #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 85.64% 86.46% +0.82%
==========================================
Files 31 34 +3
Lines 1219 1271 +52
==========================================
+ Hits 1044 1099 +55
+ Misses 175 172 -3
|
jraddaoui
force-pushed
the
dev/issue-96-static-content
branch
2 times, most recently
from
16f75cf to
1b497f6
Compare
sevein
reviewed
Jun 3, 2019
|
|
||
| class StaticContent(models.Model): | ||
| key = models.CharField(max_length=50, primary_key=True) | ||
| content = models.TextField(_("content"), blank=True) |
There was a problem hiding this comment.
@jraddaoui , wouldn't be a good idea to have the model mapped out after the concept of a "Page"? E.g. a model where you can also fit the title of the page or in the future things like its permalink? Or you're thinking on something more generic?
jraddaoui
force-pushed
the
dev/issue-96-static-content
branch
from
1b497f6 to
eed005c
Compare
jraddaoui
changed the title
cole
reviewed
Jun 3, 2019
There was a problem hiding this comment.
Nice work @jraddaoui! Some comments inline, but this code looks good generally.
jraddaoui
force-pushed
the
dev/issue-96-static-content
branch
2 times, most recently
from
3d64f0a to
4de6423
Compare
|
Thank you very much @cole! Back to you ;) |
- Create Content model with key and content fields. - Use `django-modeltranslation` to allow content field translation. - Add initial content for "home", "login" and "faq" pages. - Use numbered keys to order them and add labels for display. - Add content page to manage them in a formset. - Render content, allowing Markdown syntax.
jraddaoui
force-pushed
the
dev/issue-96-static-content
branch
from
4de6423 to
2d1cbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
django-modeltranslationto allow content field translation.Refs #96, #105.