Skip to content

Conversation

@DataM0del
Copy link
Contributor

@DataM0del DataM0del commented Mar 28, 2025

This is going to take a while to even get it to compile due to SwordItem and ArmorItem being converted to data packs. I'm coming for you Mojang, get rid of data packs now!1111!111!!!!! (/j, might be useful for the sword blocking thing, but that's like the only 1 good thing about data packs).
I probably should've reopened the old PR (#5913), but yes. (best reasoning 🤑)
Mojang will probably make everything use a data pack, so we probably are best off at some point trying to make everything ready for data packs, since this is annoying.

  • It launches (before 4eeac7a since we're updating again)
  • MCEF works (never)
  • Render shortcuts / etc are fully refactored to be reimplemented
  • (port specific) TODOs are gone
  • Fix player slowly drifting to the left (movement input issue thing? I think I mixed it up)

…t know what hasCreativeInventory is in 1.21.5
@vanvac
Copy link

vanvac commented May 3, 2025

is there a todo tracker you have setup if so approx what percent way are you through on fully updating to 1.21.5

@DataM0del
Copy link
Contributor Author

is there a todo tracker you have setup if so approx what percent way are you through on fully updating to 1.21.5

no, I'll make it now

@DataM0del
Copy link
Contributor Author

I made it, also, I'm going to actually update it this time after I paste the lb legacy movefix into my client 🤑

@Rexjosh999
Copy link

So the new update works with 1.21.5?

@vanvac
Copy link

vanvac commented May 6, 2025

So the new update works with 1.21.5?

not as of now

reading the todo on the github it only just seems to be able to launch but many stuff is still broken

@DataM0del
Copy link
Contributor Author

1.21.6 is happening... 🥱
hopefully they reverted some of the 1.21.5 changes since, well, I don't want to waste all my time trying to fix MCEF 😡

@sqlerrorthing
Copy link
Contributor

sqlerrorthing commented May 14, 2025

I don't want to waste all my time trying to fix MCEF 😡

what happends?

@DataM0del
Copy link
Contributor Author

I don't want to waste all my time trying to fix MCEF 😡

what happends?

they broke MCEF in 1.21.5 by removing some RenderSystem stuff and I had to replace it with GlStateManager stuff instead lol, also you can't tell it to register a abstract texture with a glId anymore, as that has been moved to GlTexture.
Maybe NativeImageBackedTexture might work?

@DataM0del
Copy link
Contributor Author

1.21.6 has an input packet and now uses that for sneaking... no quake 2 movement system please 🙏

@DataM0del DataM0del changed the title refactor(minecraft): update to 1.21.5 refactor(minecraft): update to 1.21.6 May 19, 2025
@vanvac
Copy link

vanvac commented May 20, 2025

im guessing since 1.21.6 is wery close to here you are focusing your efforts on making it work with the newest version rather than keeping woriking on 1.21.5 and then updating again

@DataM0del
Copy link
Contributor Author

im guessing since 1.21.6 is wery close to here you are focusing your efforts on making it work with the newest version rather than keeping woriking on 1.21.5 and then updating again

uhh... no rofl. just hoping by updating it I can fix MCEF easier on that version 💀

@DataM0del
Copy link
Contributor Author

replaced by #6303 since I'm lazy

@DataM0del DataM0del closed this Jun 21, 2025
@sqlerrorthing
Copy link
Contributor

oh no :*

@vanvac
Copy link

vanvac commented Jun 22, 2025

replacement not complete give up

@sqlerrorthing
Copy link
Contributor

you do a lot of work man 😞

@superblaubeere27
Copy link
Contributor

superblaubeere27 commented Jun 23, 2025

We can make use of the work anyway, so it's not all for nothing. I take a look at your implementation to get a second opinion on what the correct port for certain things should be.

@DataM0del DataM0del deleted the feat/minecraft/1.21.5 branch October 21, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants