fix: replace iconv with encoding_rs#1698
Merged
canihavesomecoffee merged 1 commit intoCCExtractor:masterfrom May 4, 2025
Merged
fix: replace iconv with encoding_rs#1698canihavesomecoffee merged 1 commit intoCCExtractor:masterfrom
canihavesomecoffee merged 1 commit intoCCExtractor:masterfrom
Conversation
Contributor
Author
|
The failing unit test doesn't seem to be because of this change🤔 Will look into it later |
Collaborator
|
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9e2a594...:
All tests passing on the master branch were passed completely. NOTE: The following tests have been failing on the master branch as well as the PR:
Congratulations: Merging this PR would fix the following tests:
Check the result page for more info. |
Member
It's because of the new Rust version 1.86. I've added a PR fixing it #1694 |
Contributor
Author
Ah i see, thanks |
canihavesomecoffee
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Closes #1697
The iconv crate is currently unmaintained and broken on the latest version of rust (see this issue). This PR migrates the encoding from iconv to the well maintained encoding_rs library.
Note that the rust implementation for this particular case was and still is buggy, regression tests 142, 147 and 149 all of which test this specific scenario have historically had empty output files (see here for eg), which is why the tests were passing. The C builds however, produce the proper outputs.