Implemented strlcat, stpncpy, mem(r)mem, and strchrnul #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZERICO2005
force-pushed
the
add_strlcat
branch
from
0a40e02 to
ed4ca25
Compare
ZERICO2005
force-pushed
the
add_strlcat
branch
from
ed4ca25 to
ec2b776
Compare
ZERICO2005
changed the title
ZERICO2005
commented
Oct 14, 2025
ZERICO2005
force-pushed
the
add_strlcat
branch
from
ec2b776 to
e32febd
Compare
ZERICO2005
changed the title
Member
|
nobody complained and all new tests look good and pass, so merging I guess :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements other common POSIX/GNU/BSD functions:
strlcat,stpncpy,memmem,memrmem,strrstr, andstrchrnul.This implementation of
memmemhas a time complexity of O(N^2) although O(N) algorithms do exist. The worst cases only arise when looking for "az" in "abacadaeafag...". In general, the maximum calls tomemcmpis proportional to the number of times that the first character of needle (in this casea) appears in haystack.stpncpyis faster thanstrncpyat zero paddingdst. I implemented the zero padding withlddr(1R + 1W + 1per\0) whereasstrncpyuses a6F + 1R + 1W + 1per\0loop https://github.com/pcawte/AgDev/blob/main/src/libc/strncpy.src