ci(release): disable aws-cli default checksums for R2 uploads - #25
Merged
Conversation
The runner's preinstalled aws-cli (2.34.63) enables CRC32/CRC64NVME request checksums by default (aws-cli >= 2.23). Cloudflare R2 does not implement them and rejects the PutObject calls that `aws s3 cp` issues. Set AWS_REQUEST_CHECKSUM_CALCULATION / AWS_RESPONSE_CHECKSUM_VALIDATION to when_required (the AWS/Cloudflare-documented remediation) so the R2 uploads in the Sign-and-Publish job succeed. Complements #22 (cp --recursive), which fixed the ListObjectsV2 NoSuchKey on the destination-listing path. How to verify: dispatch Publish Release (stable); Upload to R2 and Create GitHub Release both complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
AWS_REQUEST_CHECKSUM_CALCULATION=when_requiredandAWS_RESPONSE_CHECKSUM_VALIDATION=when_requiredto theUpload to R2step.Why
The runner ships
aws-cli/2.34.63. Since aws-cli 2.23 the client adds CRC32/CRC64NVME integrity checksums to requests by default; Cloudflare R2 does not implement them and rejects thePutObjectcalls thataws s3 cpissues (Cloudflare incident, Jan 2025). These env vars are the AWS/Cloudflare-documented remediation. Complements #22, which fixed theListObjectsV2NoSuchKey by switchingsync→cp --recursive.How to verify
Dispatch Publish Release (release_type=stable); the
Sign and Publish to R2job completesUpload to R2andCreate GitHub Release.Risks
None — the env vars only relax client-side integrity headers that R2 rejects; behavior when R2 supports checksums is unchanged.