Skip to content

fix(sender): specific SIGHUP reload error messages - #26

Merged
andrescera merged 1 commit into
mainfrom
fix/srtla-sighup-messages
Jun 13, 2026
Merged

fix(sender): specific SIGHUP reload error messages#26
andrescera merged 1 commit into
mainfrom
fix/srtla-sighup-messages

Conversation

@andrescera

Copy link
Copy Markdown
Member

What

Replaced generic parse-error logging in SIGHUP reload with specific, actionable messages for each failure mode:

  • File not found/unreadable: "ips file not found/unreadable: , refusing reload"
  • File empty: "ips file is empty: , refusing reload"
  • Invalid IP lines: "invalid IP on line : skipping invalid lines in "
  • Zero valid IPs: "Ignoring source IP reload from : no valid source IPs (parse error); keeping existing connections"

Why

Operators need clear diagnostics when SIGHUP reload fails. The previous generic "no valid source IPs (parse error)" message didn't distinguish between missing files, empty files, and garbage content, making troubleshooting harder.

How to verify

  1. All 19 GTest suites pass: ctest in build/
  2. New GTest cases cover each error path (8 new tests in test_sender_bootstrap)
  3. sighup-reload.sh compat scenario passes: tests/compat/scenarios/sighup-reload.sh --build-dir build
  4. No behavior change: reload guard still refuses zero-valid-IP reloads and keeps existing connections

Risks

None. This is a logging-only change; reload behavior and connection lifecycle are unchanged.


Checklist

  • Docs updated if behavior or structure changed (Rule A: no behavior change, no doc updates needed)
  • Started from updated main; branch rebased on latest canonical branch (Rule B)
  • git grep -n '.omo' -- ':!.gitignore' returns nothing (Rule D)
  • Tests pass; all 19 GTest suites green, sighup-reload.sh compat scenario passes

@andrescera
andrescera merged commit 897f80c into main Jun 13, 2026
9 checks passed
@andrescera
andrescera deleted the fix/srtla-sighup-messages branch July 17, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant