feat!: ship receiver-only .deb; deprecate C sender (replaced by srtla-send-rs) - #28
Merged
Conversation
…-send-rs) The srtla package now installs srtla_rec only. The C srtla_send is dropped from the install/package payload (CMake install rule + FPM systemd unit) but remains in-tree as a build target exercised by the full GTest suite. The device-side sender moves to srtla-send-rs (ADR-003).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected repo & language:
srtla— CMake/C++ build + CI (GitHub Actions), docsWhat
The
srtlapackage becomes receiver-only: it now installssrtla_reconly. The Csrtla_sendis dropped from the install/package payload — the CMakeinstall()rule no longer lists it, and the FPM.debstep no longer ships thesrtla-send.servicesystemd unit. The C sender source and its full GTest suite stay in-tree and still build and run; only packaging changes. Docs (AGENTS.md,README.md) mark the C sender deprecated and point tosrtla-send-rsfor the sender binary.Why
Per ADR-003, the device-side sender has moved to the Rust fork srtla-send-rs (v1.0.0 released), which is CLI- and telemetry-compatible. Shipping the C
srtla_sendalongside it would double-provide/usr/bin/srtla_sendand conflict with the fork's package. Makingsrtlareceiver-only lets the two packages coexist cleanly on the device image:srtlaprovidessrtla_rec,srtla-send-rsprovidessrtla_send. The C sender is retained in the tree as the protocol reference and to keep the compat harness' C-sender pairs runnable (Rule E — no tests deleted).How to verify
.debthe waypublish-release.ymldoes and list it:Risks
srtla-send-rsto get a sender —srtlaalone no longer provides one. This is the planned cutover (ADR-003); the fork's.debalreadyConflicts/Replaces: srtla (<< <cutover-version>), and that bound must be set to this receiver-only srtla release's version so the packages coexist.install()rule and the FPM payload line.