global: add redirection from legacy recids #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlinmack
reviewed
Sep 19, 2024
site/cds_rdm/resolver.py
Outdated
| from invenio_pidstore.resolver import Resolver | ||
|
|
||
|
|
||
| def get_pid_by_legacy_recid(pid_value): |
There was a problem hiding this comment.
nitpick: could the argument be legacy_pid_value as there's visual repetition of pid_value in the function which could be confusing
carlinmack
reviewed
Sep 19, 2024
zzacharo
approved these changes
Sep 20, 2024
kpsherva
force-pushed
the
mint-legacy-recid
branch
4 times, most recently
from
d9a372e
to
87508e8
Compare
kpsherva
force-pushed
the
mint-legacy-recid
branch
from
87508e8
to
9487215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.