Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure serial algorithms can be used inside parallel algorithms #174

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Ensure serial algorithms can be used inside parallel algorithms #174

wants to merge 3 commits into from

Conversation

tpadioleau
Copy link
Member

No description provided.

@tpadioleau tpadioleau linked an issue Sep 4, 2023 that may be closed by this pull request
Ensure serial algorithms can be used on devices #172
Open
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 9 times, most recently from 6ffecec to 15999ff Compare September 6, 2023 15:15
@tpadioleau tpadioleau marked this pull request as ready for review September 7, 2023 11:51
@tpadioleau
Copy link
Member Author

tpadioleau commented Sep 7, 2023 •
edited
Loading

I think the deepcopy algorithm has semantic issues. In this new implementation you need to pass parallel_device (or even parallel_host in fact) to trigger the copy between host and device.

@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch from 15999ff to 09068db Compare September 8, 2023 11:50
@tpadioleau tpadioleau marked this pull request as draft September 12, 2023 08:07
jbigot
jbigot previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jbigot
Copy link
Member

jbigot commented Nov 11, 2023

Is there more required to move this out of WIP status?

@tpadioleau
Copy link
Member Author

I think it is close to be ready:

  • it needs a rebase
  • maybe explore again if constexpr can only be replaced by KOKKOS_FUNCTION
  • I guess some documentation about what is possible and what is not like (callable from, executed on) ?

@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 8 times, most recently from 327a7ea to f6c3cae Compare November 24, 2023 08:50
@jbigot jbigot mentioned this pull request Feb 1, 2024
Closed
@tpadioleau tpadioleau self-assigned this Feb 16, 2024
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 2 times, most recently from 4100f03 to 0b07327 Compare February 20, 2024 09:07
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 2 times, most recently from d91c1b2 to 6e56694 Compare March 2, 2024 18:55
@tpadioleau
Copy link
Member Author

could help #193

@tpadioleau tpadioleau changed the title Generalize serial_host to serial Ensure serial algorithms can be used inside parallel algorithms Mar 4, 2024
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 2 times, most recently from 6f63a2a to aaf7255 Compare March 5, 2024 15:02
@tpadioleau tpadioleau marked this pull request as ready for review March 5, 2024 15:02
@tpadioleau tpadioleau added the enhancement New feature or request label Mar 5, 2024
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 2 times, most recently from e48bf68 to 9687396 Compare March 7, 2024 09:43
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch 3 times, most recently from 7019e16 to 23756c6 Compare March 15, 2024 13:43
jbigot
jbigot previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@jbigot jbigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

include/ddc/for_each.hpp Show resolved Hide resolved
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch from 23756c6 to 5bea366 Compare March 25, 2024 11:09
@tpadioleau tpadioleau force-pushed the 172-ensure-serial-algorithms-can-be-used-on-devices branch from 5bea366 to d02f2c1 Compare March 25, 2024 11:13
tpadioleau
tpadioleau commented Mar 25, 2024
View reviewed changes
include/ddc/for_each.hpp Outdated Show resolved Hide resolved
jbigot
jbigot reviewed Mar 28, 2024
View reviewed changes
include/ddc/for_each.hpp Outdated Show resolved Hide resolved
@tpadioleau tpadioleau marked this pull request as draft April 11, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbigot jbigot jbigot left review comments

@blegouix blegouix blegouix left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@tpadioleau tpadioleau

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure serial algorithms can be used on devices
3 participants
@tpadioleau @jbigot @blegouix