Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splines recover lapack backend #274

Closed
wants to merge 102 commits into from
Closed

Splines recover lapack backend #274

wants to merge 102 commits into from

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Jan 31, 2024 •
edited
Loading

  • Matrix classes support strided m-rhs (but spline_builder still involves transpositions, to get DimI as coalescent dimension for Ginkgo and DimI as contiguous one for Lapack. It may be improved in another MR).
  • Schur complement and several banded matrixes are implemented.
  • Ginkgo and Lapack backends are both available
  • Tests for matrices and both backends

Note: performance is pretty bad on GPU because we perform CPU<->GPU deepcopies and CPU Lapack calls in the solver. It is adressed in the #276.

@blegouix blegouix self-assigned this Jan 31, 2024
@blegouix blegouix marked this pull request as draft January 31, 2024 18:34
@blegouix blegouix changed the base branch from main to splines-minor-fixes February 1, 2024 21:19
@tpadioleau
Copy link
Member

I suggest to split this MR in 2 parts, a first part with only Matrix related files and an other one related to splines

@blegouix blegouix mentioned this pull request Mar 6, 2024
Closed
@blegouix blegouix changed the base branch from main to lapack_matrices March 6, 2024 08:25
@blegouix blegouix closed this Jun 5, 2024
@tpadioleau
Copy link
Member

tpadioleau commented Jun 5, 2024 •
edited
Loading

@blegouix Shall we keep the branch ? If so can you rename it following our convention ?

@blegouix blegouix deleted the splines-recover-lapack branch June 5, 2024 17:26
@blegouix
Copy link
Collaborator Author

blegouix commented Jun 5, 2024

I prefer to keep them at least while the others are not merged, thx for the remind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau Awaiting requested review from tpadioleau

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegouix @tpadioleau