Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSplines doc #415

Merged
merged 54 commits into from
Apr 25, 2024
Merged

BSplines doc #415

merged 54 commits into from
Apr 25, 2024

Conversation

blegouix
Copy link
Collaborator

No description provided.

@blegouix blegouix self-assigned this Apr 18, 2024
@blegouix blegouix marked this pull request as draft April 18, 2024 12:52
@blegouix blegouix marked this pull request as ready for review April 19, 2024 08:29
@blegouix
Copy link
Collaborator Author

There are several TODO which identify things I am not sure how to document and that you may know better than me what they are.

EmilyBourne
EmilyBourne requested changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These explanations seem clear to me. Well done. I am happy to approve once my grammar comments have been handled.

It could be useful to have someone less familiar with the code look over the docs though as I am probably not the target audience for these

EmilyBourne
EmilyBourne previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tpadioleau
tpadioleau reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blegouix @EmilyBourne thanks a lot for this work! I have minor suggestions/questions.

If you apply some suggestions, please make also the change in the file bsplines_uniform.hpp if they are meaningful.

include/ddc/kernels/splines/bsplines_non_uniform.hpp Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/bsplines_non_uniform.hpp Outdated Show resolved Hide resolved
tpadioleau
tpadioleau approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@blegouix blegouix merged commit c54752c into main Apr 25, 2024
44 checks passed
@blegouix blegouix deleted the splines-doc2 branch April 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilyBourne EmilyBourne EmilyBourne left review comments

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blegouix @EmilyBourne @tpadioleau