Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix classes doc #433

Merged
merged 9 commits into from
May 16, 2024
Merged

Matrix classes doc #433

merged 9 commits into from
May 16, 2024

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Apr 30, 2024 •
edited
Loading

I propose to not document those classes extensively as the API is going to change (at least, not document extensively the methods which are subject to those changes.

@blegouix blegouix self-assigned this Apr 30, 2024
@blegouix blegouix marked this pull request as draft April 30, 2024 14:24
@blegouix blegouix mentioned this pull request May 6, 2024
Closed
@blegouix blegouix added the documentation Improvements or additions to documentation label May 6, 2024
@blegouix blegouix changed the title [WIP] Matrix classes doc [Matrix classes doc May 6, 2024
@blegouix blegouix marked this pull request as ready for review May 6, 2024 09:02
@blegouix blegouix changed the title [Matrix classes doc Matrix classes doc May 6, 2024
EmilyBourne
EmilyBourne previously approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@EmilyBourne EmilyBourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

tpadioleau
tpadioleau requested changes May 14, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment is about the memory layout. It is fixed by the parent class Matrix.

include/ddc/kernels/splines/matrix.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix_sparse.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix_sparse.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix_sparse.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix_sparse.hpp Outdated Show resolved Hide resolved
include/ddc/kernels/splines/matrix_sparse.hpp Outdated Show resolved Hide resolved
@blegouix @tpadioleau
Apply suggestions from code review
a663982 
Co-authored-by: Thomas Padioleau <[email protected]>
tpadioleau
tpadioleau approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@blegouix blegouix merged commit e20602c into main May 16, 2024
44 checks passed
@blegouix blegouix deleted the matrix-doc branch May 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

@EmilyBourne EmilyBourne EmilyBourne left review comments

Assignees

@blegouix blegouix

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blegouix @EmilyBourne @tpadioleau