Splines kokkos kernels backend #480
Conversation
* Set error on old style cast and use static_cast * Modernize use nullptr
blegouix
changed the title
tpadioleau
force-pushed
the
kokkos-kernels-backend
branch
2 times, most recently
from
d8e99bd
to
59c7a13
Compare
tpadioleau
force-pushed
the
kokkos-kernels-backend
branch
from
59c7a13
to
176719d
Compare
|
@yasahi-hpc If you have time can you have a look at the following error [ 6%] Building CXX object examples/CMakeFiles/characteristics_advection.dir/characteristics_advection.cpp.o
In file included from /data/opt/kokkos-kernels/include/KokkosBatched_Gbtrs.hpp:62,
from /src/include/ddc/kernels/splines/splines_linear_problem_band.hpp:19,
from /src/include/ddc/kernels/splines/splines_linear_problem_maker.hpp:12,
from /src/include/ddc/kernels/splines/spline_builder.hpp:15,
from /src/include/ddc/kernels/splines.hpp:17,
from /src/examples/characteristics_advection.cpp:12:
/data/opt/kokkos-kernels/include/KokkosBatched_Gbtrs_Serial_Impl.hpp:21:10: fatal error: ../src/KokkosBatched_Tbsv.hpp: No such file or directory
21 | #include "../src/KokkosBatched_Tbsv.hpp"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.My guess is that the path is not valid when the library gets installed ? |
|
@tpadioleau |
…lation/ddc into kokkos-kernels-backend
What branch are we based on ? I guess @blegouix just did the update but I am still interested in the answer |
|
|
Failures. I guess I need to include |
I let you see about it, if you get a circular dependency you can also use forward declarations. |
|
It should be OK now.
We do not have a circular dependency here. I just included a wrong file |
|
all green! |
|
@tpadioleau should I rename |
It is ok for now, let's keep LAPACK |
This reverts commit a10aace.
|
@yasahi-hpc I revert your commit after our discussion, we do not need push/pop with nvtx-connector |
No description provided.