Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplineBuilder minor optimization #517

Merged
merged 3 commits into from
Jul 4, 2024
Merged

SplineBuilder minor optimization #517

merged 3 commits into from
Jul 4, 2024

Conversation

blegouix
Copy link
Collaborator

@blegouix blegouix commented Jul 2, 2024

  • spline_tr was allocating too much rows (they were unused).
  • Rely on ddc::parallel_fill and Kokkos::deep_copy to fill splines with vals

@blegouix blegouix marked this pull request as draft July 2, 2024 09:01
@blegouix blegouix self-assigned this Jul 2, 2024
@blegouix blegouix marked this pull request as ready for review July 2, 2024 11:11
@blegouix blegouix mentioned this pull request Jul 2, 2024
Closed
@blegouix blegouix requested a review from tpadioleau July 2, 2024 11:12
tpadioleau
tpadioleau reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, the change seems fine to me.

tpadioleau
tpadioleau requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass an instance of execution space to parallel_fill and deep_copy

@blegouix blegouix merged commit 97099de into main Jul 4, 2024
49 checks passed
@blegouix blegouix deleted the spline-builder-optimize branch July 4, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@blegouix blegouix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blegouix @tpadioleau