Misc fixes to make codegen-llvm tests work on CHERIoT #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xdoardo
force-pushed
the
needs-target-std-codegen-llvm
branch
4 times, most recently
from
7a8fd4f to
76dd6bb
Compare
seharris
reviewed
Jan 13, 2026
Collaborator
seharris
left a comment
seharris
left a comment
There was a problem hiding this comment.
Other than the issue with CHERIoT being classified as 64 bit, this looks ok to me.
xdoardo
force-pushed
the
needs-target-std-codegen-llvm
branch
4 times, most recently
from
f32941c to
b1e5f66
Compare
seharris
reviewed
Jan 14, 2026
…ileCheck and make some tests no_std ...also add this part of the testsuite in CI.
…pace from target family
xdoardo
force-pushed
the
needs-target-std-codegen-llvm
branch
from
b1e5f66 to
d479810
Compare
seharris
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some work for #59 and #50.
rust-lang/rust#150672 is already part of this PR because some tests - specifically those that test the debug info that rust generates - fail if a new line is added to the file. We can change the behaviour added here later if the patch to upstream Rust is rejected.
I'd like to keep this PR with two commits in it: one for the bit that's also upstreamed and one for the set of changes to the tests. The associated CI job will thus fail, but that won't block merging this.
This patch already marks some tests as ignore+FIXME for CHERIoT.