-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hipGraph API fixes & "native" Graph implementation #560
base: main
Are you sure you want to change the base?
Commits on Jul 24, 2023
-
Update OpenCL headers in include/CL
this is required for cl_khr_command_buffer
Configuration menu - View commit details
-
Copy full SHA for 36b6feb - Browse repository at this point
Copy the full SHA 36b6febView commit details -
Configuration menu - View commit details
-
Copy full SHA for 905ff02 - Browse repository at this point
Copy the full SHA 905ff02View commit details -
add include/CL/cl_ext_pocl.h (required for command buffer extensions)
CL/opencl.h: include cl_ext_pocl.h but exclude cl_gl_ext.h (now just redirects to cl_ext.h)
Configuration menu - View commit details
-
Copy full SHA for cdc8282 - Browse repository at this point
Copy the full SHA cdc8282View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2104c36 - Browse repository at this point
Copy the full SHA 2104c36View commit details -
Implement chipstar::GraphNative
This class is used to implement Graphs that execute "natively" in the backend, using OpenCL command-buffers or LevelZero command-lists and only synchronizing with the host when required. Fallback to original Graph is provided in chipstar::GraphExec::launch() Add more error-checking to the hipGraphXYZ APIs & bugfixes Additionally, samples/graph + samples/graphMatrixMultiply work using the "native graphs" (cl_command_buffer), not the original chip-spv's graph execution. Merged style fixes by Henry. Co-authored-by: Henry Linjamäki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7be5794 - Browse repository at this point
Copy the full SHA 7be5794View commit details -
update unit tests with failing/passing Graph tests
move graph tests to FAILING_FOR_ALL
Configuration menu - View commit details
-
Copy full SHA for 5f6a368 - Browse repository at this point
Copy the full SHA 5f6a368View commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e2d624 - Browse repository at this point
Copy the full SHA 4e2d624View commit details
Commits on Aug 2, 2023
-
fix issue with GraphNodeKernel constructors
the constructors were copying the value of Args pointer, instead of making an actual copy of the arguments. This can lead to a crash if the Args pointer lives on the stack, later goes out of scope, and setupAllArgs() is called.
Configuration menu - View commit details
-
Copy full SHA for 83ee3d8 - Browse repository at this point
Copy the full SHA 83ee3d8View commit details