Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed setup process #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fixed setup process #73

wants to merge 3 commits into from

Conversation

sgriffithjones
Copy link

The Setup process tweaks for oceanmesh to be ran on win_x64.

@krober10nd
Copy link
Collaborator

hey @sgriffithjones thanks! however it seems like it needs the gmp and mpfr libraries per the error messages for the various builds.

@sgriffithjones
Copy link
Author

hey @sgriffithjones thanks! however it seems like it needs the gmp and mpfr libraries per the error messages for the various builds.

hi @krober10nd. I believe my newest commit fixes that issue. setup.py ln 39 should read:
Pybind11Extension(loc, [fi], libraries=["gmp", "mpfr"])
not
Pybind11Extension(loc, [fi])

@sgriffithjones
Copy link
Author

Apologies, for testing purposes I commented out the @pytest.mark.skip(reason="not implemented yet") in the test bathymetric file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgriffithjones @krober10nd