Automated code formatting #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
requested changes
May 16, 2024
There was a problem hiding this comment.
Hi @nicolossus
Cool! Please remove the test_data folder from linting though, because these are datasets generated by the acquisition systems.
Can you revert the changes on those files too?
@alejoe91 Fixed 👍 |
nicolossus
commented
May 16, 2024
pyproject.toml
Outdated
| "ipywidgets>=8.1.1", | ||
| "nwbwidgets>=0.11.3", | ||
| "tbb>=2021.11.0", | ||
| "tbb>=2021.11.0", # TODO: pip can't find tbb or tbb4py (at least on macOS). Is it needed? |
There was a problem hiding this comment.
this is supposed to run on educloud, and tbb is needed there
There was a problem hiding this comment.
I see. 8d8e408 proposes a solution that will let the package be installable on macOS with tbb listed in the requirements:
dependencies = [
...
"tbb>=2021.11.0; platform_system != 'Darwin'",
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automated code formatting and linting via
pre-commithooks. The PR also reformats the entire codebase and fix warnings from the linter.(Note that the PR is against the
bug-fixesbranch, as this is the most recent.)