-
Notifications
You must be signed in to change notification settings - Fork 0
Pull request templete #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
8bc4ae3
18a3ec5
f58f227
e3cd58a
49cd1f3
20b8ddb
2f062f8
376c23d
f83e43d
0026a7c
f31b7ea
7e8f8cb
85e6371
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| ## π‘ λ°°κ²½ λ° κ°μ | ||
|
|
||
| > PRμ νκ² λ λ¬Έμ μν©, λ°°κ²½ λ° κ°μμ λν΄μ μμ±ν΄μ£ΌμΈμ! | ||
| > | ||
| > νΌλΈλ¦¬μ±μ κ²½μ° μ€ν¬λ¦°μ·/λμμλ μΆκ°ν΄μ£Όλ©΄ μ’μμ! | ||
|
|
||
| Resolves: #{μ΄μλ²νΈ} | ||
|
|
||
| ## π μμ λ΄μ© | ||
|
|
||
| > PRμμ ν μμ μ μμ±ν΄μ£ΌμΈμ! | ||
|
|
||
| ## πββοΈ λ¦¬λ·°λ ΈνΈ | ||
|
|
||
| > ꡬν μμ κ³ λ―Όμ΄μλ μ λ€ νΉμ νΉμ λΆλΆμ λν μλκ° μμλ€λ©΄ PR 리뷰μ μ΄ν΄λ₯Ό λκΈ° μν΄ μμ ν΄μ£ΌμΈμ! | ||
| > | ||
| > λν 리뷰μ΄μκ² νΉμ λΆλΆμ λν μ§μ€ νΉμ μ½λ©νΈ νΉμ μ§λ¬Έμ μμ²νλ κ²½μ°μ μμ±νλ©΄ μ’μμ! | ||
| > | ||
| > e.g. μμ μ λλ΄μΌν μκ°μ΄ μΌλ§ μμ΄ νμ₯μ±λ³΄λ€λ λμμ μμ£Όλ‘ λ§λ€μμ΄μ! κ°μνκ³ λ¦¬λ·°ν΄μ£ΌμΈμ! | ||
|
|
||
| ## β PR 체ν¬λ¦¬μ€νΈ | ||
|
|
||
| > ν νλ¦Ώ 체ν¬λ¦¬μ€νΈ λ§κ³ λ μΆκ°μ μΌλ‘ νμν 체ν¬λ¦¬μ€νΈλ μΆκ°ν΄μ£ΌμΈμ! | ||
|
|
||
| - [ ] μ΄ μμ μΌλ‘ μΈν΄ λ³κ²½μ΄ νμν λ¬Έμκ° λ³κ²½λμλμ? (e.g. `.env`, `λ Έμ `, `README`) | ||
| - [ ] μ΄ μμ μ νκ³ λμ 곡μ ν΄μΌν νμλ€μκ² κ³΅μ λμλμ? (e.g. `"API κ°λ° μλ£λμ΄μ"`, `"νκ²½κ° μΆκ°λμμ΄μ"`) | ||
| - [ ] μμ ν μ½λκ° μ μμ μΌλ‘ λμνλμ? | ||
| - [ ] Merge λμ λΈλμΉκ° μ¬λ°λ₯Έκ°μ? | ||
| - [ ] PRκ³Ό κ΄λ ¨ μλ μμ μ΄ μμ§λ μλμ? | ||
|
|
||
| ## πΈ κΈ°ν | ||
|
|
||
| > μ νλͺ©μ ν΄λΉνμ§ μλ 곡μ μ¬νμ΄ μλ€λ©΄ μμ±ν΄μ£ΌμΈμ! | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: npm | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| open-pull-requests-limit: 10 | ||
| ignore: | ||
| - dependency-name: 'expo*' | ||
| - dependency-name: 'react-native*' | ||
|
Comment on lines
+8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expo νλ‘μ νΈμμλ React λ° React DOM λ²μ μ΄ Expo SDK λ²μ κ³Ό μ격νκ² λκΈ°νλμ΄μΌ ν©λλ€. Dependabotμ΄ ignore:
- dependency-name: 'expo*'
- dependency-name: 'react-native*'
- dependency-name: 'react'
- dependency-name: 'react-dom' |
||
|
|
||
| - package-ecosystem: github-actions | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: CodeQL | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| pull_request: | ||
| branches: [main, develop] | ||
| schedule: | ||
| - cron: '0 3 * * 1' | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| analyze: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| security-events: write | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: github/codeql-action/init@v3 | ||
| with: | ||
| languages: javascript-typescript | ||
|
|
||
| - uses: github/codeql-action/analyze@v3 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Commitlint | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [main, develop] | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| commitlint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
|
|
||
| - run: npm install | ||
|
|
||
| - uses: wagoid/commitlint-github-action@v6 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: E2E (Maestro) | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| e2e: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
|
|
||
| - run: npm install | ||
|
|
||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
|
|
||
| - name: Prebuild Android project | ||
| run: npx expo prebuild --platform android --no-install | ||
|
|
||
| - name: Cache Gradle | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.gradle/caches | ||
| ~/.gradle/wrapper | ||
| key: gradle-${{ runner.os }}-${{ hashFiles('android/**/*.gradle*', 'android/gradle/wrapper/gradle-wrapper.properties') }} | ||
|
|
||
| - name: Build debug APK | ||
| working-directory: android | ||
| run: ./gradlew assembleDebug --no-daemon | ||
|
|
||
| - name: Install Maestro | ||
| run: | | ||
| curl -Ls "https://get.maestro.mobile.dev" | bash | ||
| echo "$HOME/.maestro/bin" >> "$GITHUB_PATH" | ||
|
|
||
| - name: Run Maestro E2E on emulator | ||
| uses: reactivecircus/android-emulator-runner@v2 | ||
| with: | ||
| api-level: 34 | ||
| arch: x86_64 | ||
| profile: pixel_6 | ||
| script: | | ||
| adb install -r android/app/build/outputs/apk/debug/app-debug.apk | ||
| maestro test .maestro |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: EAS Build (Android) | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
|
|
||
| - run: npm install | ||
|
|
||
| - uses: expo/expo-github-action@v8 | ||
| with: | ||
| eas-version: latest | ||
| token: ${{ secrets.EXPO_TOKEN }} | ||
|
|
||
| - run: eas build --platform android --profile production --non-interactive |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: Secret Scan | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] | ||
| pull_request: | ||
| branches: [main, develop] | ||
|
|
||
| concurrency: | ||
| group: ci-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| gitleaks: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Run gitleaks | ||
| run: | | ||
| docker run --rm -v "$PWD:/repo" zricethezav/gitleaks:latest \ | ||
| detect --source=/repo --redact --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
νμΌλͺ μ μ€νκ° μμ΅λλ€.
PULL_REQUEST_TEMPLETE.MDλμpull_request_template.md(λλPULL_REQUEST_TEMPLATE.md)λ‘ λ³κ²½ν΄μΌ GitHubμμ PR ν νλ¦ΏμΌλ‘ μ¬λ°λ₯΄κ² μΈμν©λλ€. 'TEMPLETE'λ 'TEMPLATE'μ μ€νμ λλ€.