Skip to content

Jackson Swagger 요청 로깅 공통 설정 추가 - #11

Merged
cfcromn merged 2 commits into
developfrom
feat/10-jackson-swagger-request-logging
Jul 14, 2026
Merged

cfcromn merged 2 commits into
developfrom
feat/10-jackson-swagger-request-logging

Conversation

@cfcromn

@cfcromn cfcromn commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

✨ 작업 내용

Jackson strict JSON 처리, Swagger 경로·보안, 요청 메타데이터 로깅을 추가했습니다.

  • unknown JSON field를 UNKNOWN_JSON_FIELD 400 응답으로 처리
  • ISO-8601 시간 직렬화 및 swagger 경로 설정
  • UUID request ID 응답 헤더와 메타데이터 요청 로그
  • Spring Boot 3.5 호환 springdoc 2.8.17로 업데이트

🔍 리뷰 시 참고사항

  • 요청·응답 본문, Authorization, Cookie, 쿼리 파라미터는 로그에 기록하지 않습니다.
  • Swagger/OpenAPI와 actuator 요청은 공통 요청 로그에서 제외합니다.

✅ 체크리스트

  • 문서 또는 환경 설정 변경을 반영했습니다.
  • 전체 테스트를 실행했습니다.
  • 필요한 통합 테스트를 추가했습니다.
  • Merge 대상 브랜치는 develop입니다.
  • 관련 없는 작업은 포함하지 않았습니다.
  • 적절한 라벨과 리뷰어를 설정했습니다.

📎 관련 이슈(선택)

@cfcromn
cfcromn requested a review from exijn July 14, 2026 02:43
@cfcromn cfcromn self-assigned this Jul 14, 2026
@cfcromn cfcromn added ⚙ Setting 환경 세팅 1️⃣ Priority: High 우선순위 - 상 labels Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces request logging via RequestLoggingFilter, configures Jackson to fail on unknown properties and serialize dates as ISO-8601 strings, and handles unrecognized JSON fields gracefully in GlobalExceptionHandler. It also updates Springdoc OpenAPI dependencies and adds corresponding integration tests. The reviewer feedback suggests several robust improvements: handling potential context paths in the logging filter, excluding Resource types from response wrapping in CommonResponseAdvice to support file downloads, and explicitly handling MissingKotlinParameterException in the exception handler to provide clearer feedback for missing required fields.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/kotlin/team/cklob/arena/global/common/RequestLoggingFilter.kt Outdated
@cfcromn
cfcromn merged commit 4442a7f into develop Jul 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1️⃣ Priority: High 우선순위 - 상 ⚙ Setting 환경 세팅

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants