Skip to content

공통 API 응답 및 JWT 보안 기반 구축 - #9

Merged
cfcromn merged 6 commits into
developfrom
feat/8-common-response-jwt-security
Jul 13, 2026
Merged

공통 API 응답 및 JWT 보안 기반 구축#9
cfcromn merged 6 commits into
developfrom
feat/8-common-response-jwt-security

Conversation

@cfcromn

@cfcromn cfcromn commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

✨ 작업 내용

공통 API 응답 및 예외 처리, Stateless JWT Bearer 보안 기반을 추가했습니다.

  • ErrorCode와 ExpectedException 기반의 비즈니스 오류 응답
  • 검증, JSON 파싱, 타입, HTTP 메서드 오류 전역 처리
  • 공통 성공 응답 래핑 및 OpenAPI Bearer 스키마
  • JWT 검증 필터와 인증/인가 공통 오류 응답

🔍 리뷰 시 참고사항

  • OAuth2 공급자 연동, 로그인 API, 리프레시 토큰은 이번 범위에서 제외했습니다.
  • JWT secret은 JWT_SECRET 환경 변수로 주입해야 합니다.

✅ 체크리스트

  • 문서 또는 환경 설정 변경을 반영했습니다.
  • 전체 테스트를 실행했습니다.
  • 필요한 통합 테스트를 추가했습니다.
  • Merge 대상 브랜치는 develop입니다.
  • 관련 없는 작업은 포함하지 않았습니다.
  • 적절한 라벨과 리뷰어를 설정했습니다.

📎 관련 이슈(선택)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces security and common API response infrastructure to the application, including JWT authentication, a global exception handler, custom error codes, and OpenAPI configuration. The reviewer provided several constructive suggestions: allowing non-Bearer Authorization headers to pass through the filter chain to prevent blocking public APIs, simplifying validation exception handling by leveraging the inheritance of BindException, ensuring robustness when decoding the JWT secret, utilizing JJWT 0.12+ Instant support directly, and adding /swagger-ui.html to the permitted request matchers to avoid redirection issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/kotlin/team/cklob/arena/global/security/SecurityConfig.kt
@cfcromn cfcromn added ⚙ Setting 환경 세팅 1️⃣ Priority: High 우선순위 - 상 labels Jul 13, 2026
@cfcromn
cfcromn requested a review from exijn July 13, 2026 11:44
@cfcromn cfcromn self-assigned this Jul 13, 2026
@cfcromn
cfcromn merged commit e805b5b into develop Jul 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1️⃣ Priority: High 우선순위 - 상 ⚙ Setting 환경 세팅

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants