Skip to content

전역 공통 설정 모듈 추가 - #13

Merged
cfcromn merged 2 commits into
developfrom
feature/12-global-common-config
Jul 20, 2026
Merged

전역 공통 설정 모듈 추가#13
cfcromn merged 2 commits into
developfrom
feature/12-global-common-config

Conversation

@cfcromn

@cfcromn cfcromn commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

✨ 작업 내용

  • 전역 예외 처리와 공통 API 응답 형식을 추가하였습니다.
  • JWT 발급·검증, 인증 필터, @LoginUser ArgumentResolver와 보안 경로 정책을 추가하였습니다.
  • Redis Kotlin 직렬화, Jackson, Swagger, 비동기 설정을 추가하였습니다.
  • 예외 처리, JWT, Redis, 보안 경로에 대한 테스트를 추가하였습니다.

🔍 리뷰 시 참고사항

  • 기존 BaseTimeEntity@EnableJpaAuditing 구현은 재사용하였습니다.
  • JWT_SECRET은 환경변수에서 주입되도록 구성하였습니다.
  • 인증 없이 보호 경로에 접근하면 401을 반환하며, 유효 JWT는 보호 경로 접근을 허용하도록 검증하였습니다.
  • Swagger UI와 OpenAPI의 bearerAuth 보안 스킴을 로컬 실행으로 확인하였습니다.

✅ 체크리스트

  • 문서(README, .env.example 등) 변경이 필요한 경우 작성 또는 수정했나요? (기존 .env.exampleJWT_SECRET이 있어 변경하지 않았습니다.)
  • 작업한 코드가 정상적으로 동작하는 것을 직접 확인했나요? (./gradlew test, Swagger UI 확인)
  • 필요한 경우 테스트 코드를 작성하거나 수정했나요?
  • Merge 대상 브랜치를 올바르게 설정했나요? (develop)
  • PR에 관련 없는 작업이 포함되지 않았나요?
  • 적절한 라벨과 리뷰어를 설정했나요? (라벨: ✨ Feature, ✅ Test)

📎 관련 이슈(선택)

@cfcromn cfcromn added ✅ Test Test관련사항 ✨ Feature 신규 기능 labels Jul 20, 2026
@cfcromn
cfcromn requested a review from exijn July 20, 2026 00:50
@cfcromn cfcromn self-assigned this Jul 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request sets up the global infrastructure for a Kotlin Spring Boot application, including configurations for Async, Jackson, Redis, Security, Swagger, and Web MVC, alongside custom JWT authentication and global exception handling. The reviewer provided highly valuable feedback to improve robustness and security: avoiding direct overriding of the ObjectMapper to preserve Spring Boot's default modules, expanding the Redis polymorphic type validator to allow standard Java collections, properly handling unauthorized exceptions in Spring Security to avoid issues with /error forwarding, strictly validating the Bearer prefix in the JWT filter, handling non-nullable parameters in the LoginUser resolver, and logging unexpected exceptions in the global handler.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/kotlin/team/cklob/mudda/global/config/JacksonConfig.kt Outdated
Comment thread src/main/kotlin/team/cklob/mudda/global/config/RedisConfig.kt
Comment thread src/main/kotlin/team/cklob/mudda/global/config/SecurityConfig.kt Outdated
Comment thread src/main/kotlin/team/cklob/mudda/global/security/JwtAuthenticationFilter.kt Outdated
Comment thread src/main/kotlin/team/cklob/mudda/global/security/LoginUserArgumentResolver.kt Outdated
Comment thread src/main/kotlin/team/cklob/mudda/global/exception/GlobalExceptionHandler.kt Outdated
@cfcromn
cfcromn merged commit 4829466 into develop Jul 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 신규 기능 ✅ Test Test관련사항

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants