Version1.2 #123
Version1.2 #123
Conversation
Also updates documentation. Passes check()
Passes check()
Convert dates into a more readable "Month Year" format for the character column, and update the default table to accommodate new format.
read.csv can read a url directly, while read_excel() can't. So, the transition read.csv eliminates the need for the temp file download... and therefore for the RCurl package.
- function now does not need any special packages. @dlcomeaux 's new work already eliminated the need for lubridate, and there was no actual reason to store the data `as_tibble()`. -rearranged some dplyr commands to eliminate some steps ... same actions are being taken, just fewer pipes. - sysdata.rda is now updated with the new recessions table--it's the same, just a df now, not a tibble - caught a few typos in the man file for this function.
I forgot the elegant hell of ggproto objects. Seems to work. Would appreciate some additional testing @dlcomeaux
creation of numeric dates only occurs if numeric axis specified. lubridate import established and package marked as required. readxl removed from suggests.
Fixes bug, allows for current recessions
Notes the location of the recessions table
Doesn't work quite yet.
Replaced by pretty_breaks
Replaced by pretty_breaks
This reverts commit 1a3f270.
This reverts commit e1bba87.
Addresses outstanding issues, adds ability for date scales, and adds documentation
I'm going to merge this now. We can continue to capture documentation changes in the feature branches we add to 1.2, or into the 1.2 branch directly.
Follow's Matt's suggestion. Updates documentation and passes `check`.
Addresses some (not all) of Matt's comments
|
@matthewstern I prefer the simpler solution. I can implement it. If others want to do the more complex one eventually, that's fine with me, but for now, I think that's a relatively low priority. |
|
I want to point out that the results of Palette: Gradient: |
|
Ah, that is a good point, @nmpeterson . I am pretty busy this week, so I don't know that I have time to do that right now. I could look at it next week if we haven't gotten to it yet. |
- moved all palettes to tibble in globals - removed `cmap_gradients` and `cmap_palettes` objects - adjusted `viz_gradient` and `cmap_pal_continuous` fns to use this new setup. Outstanding: - adjust discrete functions accordingly - update namespace and DESCRIPTION - adjust documentation, including and especially the `cmap_palettes` and `cmap_gradients` objects. Consider combining these into a single help page.
|
FYI I'm working on these adjustments in the branch |
still need to do discrete and race and update documentation.
Red is way too aggressive to be the default, and also not very CMAP-y.
These categories are pretty unlikely to change in the future
Updating man files
Minor tweaks
Minor update to vignette, could cut if @matthewstern you think this is unnecessary.
…into color_tweaks
Color tweaks
This PR will encapsulate all changes for cmapplot v1.2.
This list accounts for all changes merged into the branch so far (please update as you merge):
update_recessions()#89, PR Fixes bug, allows for current recessions #122)dateandcontinuousscales; issue improved x axis control in TS #26, PR Allow for abbreviating years to two-digit versions #126)cmapplot_globals.Randutilities.R(PR Systemfonts and friends #128)cmap_[color/fill]_discrete()(issues discrete option for continuous palettes #70 & unable to use cmapplot continuous color palettes for fill aesthetic #119, PR Allow for discrete versions of gradients #131).raggversions and disabledwindowmode. Did not implementsvglite, although that remains a long-term goal (issue v1.2 font handling and output goals #127 covers what was implemented and issue Implementing svglite #134 details what was not; changes are merged from PR finalize w/ systemfonts & ragg #130)