Me/dpc 4549 update logging #2505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 5e72c02 Author: Christopher Ronning <[email protected]> Date: Fri Mar 7 09:48:46 2025 -0500 [DPC-4550] Foundational code for load tests (#2504) ## 🎫 Ticket https://jira.cms.gov/browse/DPC-4550 ## 🛠 Changes - Fetch org-level admin token - Set up resource bodies for POST requests - setup function to create organizations, and assertions for it - Get organizations as a test - Splits code into workflows - Sets up token management ## ℹ️ Context This creates some foundational code for our load testing, upon which the rest of our work can be built. <!-- Why were these changes made? Add background context suitable for a non-technical audience. --> <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation <!-- How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable. --> - [ ] Tests run successfully on local machine <img width="972" alt="Screenshot 2025-03-06 at 1 07 58 PM" src="https://github.com/user-attachments/assets/85cbe6f8-5501-48c9-98b5-dc4cbfbc6dbb" /> commit b8f5c13 Author: Ashley Weaver <[email protected]> Date: Thu Mar 6 15:43:03 2025 -0500 [DPC-4559] Update ci-workflow.yml (#2502) ## 🎫 Ticket https://jira.cms.gov/browse/DPC-4559 ## 🛠 Changes Updates workflow to use ubuntu-latest. ## ℹ️ Context @bhodges-navapbc noticed that one of our workflows was using a version of ubuntu that is near EOL. ## 🧪 Validation Workflow passing. commit e5e747f Author: Ashley Weaver <[email protected]> Date: Wed Mar 5 17:02:28 2025 -0500 Update rack (#2501) ## 🎫 Ticket No ticket. ## 🛠 Changes Update vulnerable gem. ## ℹ️ Context <!-- Why were these changes made? Add background context suitable for a non-technical audience. --> <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation <!-- How were the changes verified? Did you fully test the acceptance criteria in the ticket? Provide reproducible testing instructions and screenshots if applicable. -->
This reverts commit fb534dd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4549
🛠 Changes
ℹ️ Context
We recently had a number of batches that took way too long to complete and haven't been able to definitively pinpoint why. These changes should help narrow it down, specifically if we're having trouble loading resources from BFD.
Our default logging level is set to WARN, and any resource fetch that runs under 30 seconds is logged at INFO so they won't be clogging up our logs. Fetches that take longer than 30 seconds are logged at WARN so they will show up in our logs.
I considered setting up something like this in the BFD client itself, but it already has a 5 second timeout so no queries can run longer than that.
🧪 Validation
Deployed to test and verified that the new logs are getting written and parsed correctly in Splunk:
