Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

分页判断 #37

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

分页判断 #37

wants to merge 3 commits into from

Conversation

melancn
Copy link

@melancn melancn commented Jun 18, 2017

No description provided.

@@ -58,6 +60,9 @@ protected function getView(Request $request)
$sort = array_pull($queryParams, 'sort');
$q = array_pull($queryParams, 'q');
$page = array_pull($queryParams, 'page', 1);
$discussion = new Discussion();
$totledis = $discussion->count();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totle? total?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为了后人的可维护性。就是totle了!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是改了吧,黑历史啊

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nroskill @Gizeta 删掉这一段!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants